tec3/five-for-the-future
tec3/five-for-the-future
1
0
Fork 0
mirror of https://github.com/WordPress/five-for-the-future.git synced 2025-07-04 18:05:45 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Pledge Meta: Ensure generated meta values are actually generated

Browse source 
I made the incorrect assumption that the `$meta_type` in
`update_{$meta_type}_meta` was the cpt ID, when it really wanted just
`post`. :/
This commit is contained in:
Corey McKrill 2019-10-18 16:01:09 -07:00
parent c35efea8b7
commit 2846344b72
No known key found for this signature in database
GPG key ID: C2C0746F7BF17E38
1 changed files with 14 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

19
plugins/wporg-5ftf/includes/pledge-meta.php
View file

@ -14,11 +14,14 @@ defined( 'WPINC' ) || die();
const META_PREFIX = FiveForTheFuture\PREFIX . '_'; const META_PREFIX = FiveForTheFuture\PREFIX . '_';
add_action( 'init', __NAMESPACE__ . '\register_pledge_meta' ); add_action( 'init', __NAMESPACE__ . '\register_pledge_meta' );
add_action( 'admin_init', __NAMESPACE__ . '\add_meta_boxes' ); add_action( 'admin_init', __NAMESPACE__ . '\add_meta_boxes' );
add_action( 'save_post', __NAMESPACE__ . '\save_pledge', 10, 2 ); add_action( 'save_post', __NAMESPACE__ . '\save_pledge', 10, 2 );
add_action( 'updated_' . Pledge\CPT_ID . '_meta', __NAMESPACE__ . '\update_generated_meta', 10, 4 ); add_action( 'admin_enqueue_scripts', __NAMESPACE__ . '\enqueue_assets' );
add_action( 'admin_enqueue_scripts', __NAMESPACE__ . '\enqueue_assets' );
// Both hooks must be used because `updated` doesn't fire if the post meta didn't previously exist.
add_action( 'updated_postmeta', __NAMESPACE__ . '\update_generated_meta', 10, 4 );
add_action( 'added_post_meta', __NAMESPACE__ . '\update_generated_meta', 10, 4 );
/** /**
* Define pledge meta fields and their properties. * Define pledge meta fields and their properties.
@ -243,6 +246,12 @@ function save_pledge_meta( $pledge_id, $new_values ) {
* @return void * @return void
*/ */
function update_generated_meta( $meta_id, $object_id, $meta_key, $_meta_value ) { function update_generated_meta( $meta_id, $object_id, $meta_key, $_meta_value ) {
$post_type = get_post_type( $object_id );
if ( Pledge\CPT_ID !== $post_type ) {
return;
}
switch ( $meta_key ) { switch ( $meta_key ) {
case META_PREFIX . 'org-url': case META_PREFIX . 'org-url':
$domain = get_normalized_domain_from_url( $_meta_value ); $domain = get_normalized_domain_from_url( $_meta_value );