tec3/five-for-the-future
tec3/five-for-the-future
1
0
Fork 0
mirror of https://github.com/WordPress/five-for-the-future.git synced 2025-07-03 01:31:17 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Move logo uploading to a separate function, and rely on core checks for mime & filesize checking

Browse source
This commit is contained in:
Kelly Dwan 2019-10-25 12:03:17 -04:00
parent e779397ce4
commit 3a943e9c58
No known key found for this signature in database
GPG key ID: 8BA5575F3D11575D
1 changed files with 70 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

84
plugins/wporg-5ftf/includes/pledge-form.php
View file

@ -61,19 +61,9 @@ function process_form_new() {
return $contributors; return $contributors;
} }
// Process image. $logo_attachment_id = upload_image( $_FILES['org-logo'] );
if ( ! function_exists('media_handle_upload') ) { if ( is_wp_error( $logo_attachment_id ) ) {
require_once( ABSPATH . 'wp-admin/includes/image.php' ); return $logo_attachment_id;
require_once( ABSPATH . 'wp-admin/includes/file.php' );
require_once( ABSPATH . 'wp-admin/includes/media.php' );
}
$logo = isset( $_FILES['org-logo'] ) ? $_FILES['org-logo'] : false;
if ( $logo ) {
$logo_id = \media_handle_sideload( $logo, 0 );
if ( is_wp_error( $logo_id ) ) {
return $logo_id;
}
} }
$name = sanitize_meta( $name = sanitize_meta(
@ -93,7 +83,12 @@ function process_form_new() {
Contributor\create_new_contributor( $wporg_username, $new_pledge_id ); Contributor\create_new_contributor( $wporg_username, $new_pledge_id );
} }
set_post_thumbnail( $new_pledge_id, $logo_id ); // Attach logo to the pledge.
wp_update_post( array(
'ID' => $logo_attachment_id,
'post_parent' => $new_pledge_id,
) );
set_post_thumbnail( $new_pledge_id, $logo_attachment_id );
return 'success'; return 'success';
} }
@ -291,3 +286,64 @@ function validate_submission( $submission ) {
return false; return false;
} }
/**
* Upload the logo image into the media library.
*
* @param array $logo $_FILES array for the uploaded logo.
* @return int|WP_Error Upload attachment ID, or WP_Error if there was an error.
*/
function upload_image( $logo ) {
if ( ! $logo ) {
return false;
}
// Process image.
if ( ! function_exists('media_handle_upload') ) {
require_once ABSPATH . 'wp-admin/includes/image.php';
require_once ABSPATH . 'wp-admin/includes/file.php';
require_once ABSPATH . 'wp-admin/includes/media.php';
}
if ( ! function_exists('check_upload_size') ) {
require_once ABSPATH . 'wp-includes/ms-functions.php';
require_once ABSPATH . 'wp-admin/includes/ms.php';
}
add_filter( 'upload_mimes', __NAMESPACE__ . '\safelist_image_mimes' );
add_filter( 'pre_site_option_fileupload_maxk', __NAMESPACE__ . '\restrict_file_size' );
add_filter( 'wp_handle_sideload_prefilter', 'check_upload_size' );
$logo_id = \media_handle_sideload( $logo, 0 );
remove_filter( 'upload_mimes', __NAMESPACE__ . '\safelist_image_mimes' );
remove_filter( 'pre_site_option_fileupload_maxk', __NAMESPACE__ . '\restrict_file_size' );
remove_filter( 'wp_handle_sideload_prefilter', 'check_upload_size' );
return $logo_id;
}
/**
* Only allow image mime types.
*
* @param array $mimes Mime types keyed by the file extension regex corresponding to those types.
*/
function safelist_image_mimes( $mimes ) {
return array(
'jpg|jpeg|jpe' => 'image/jpeg',
'gif' => 'image/gif',
'png' => 'image/png',
'bmp' => 'image/bmp',
'tiff|tif' => 'image/tiff',
'ico' => 'image/x-icon',
);
}
/**
* Restrict images uploaded by this form to be less than 5MB.
*
* @param bool $value Null– returning a value will short-circuit the option lookup.
*/
function restrict_file_size( $value ) {
return 5 * MB_IN_BYTES;
}