tec3/five-for-the-future
tec3/five-for-the-future
1
0
Fork 0
mirror of https://github.com/WordPress/five-for-the-future.git synced 2025-04-21 10:33:44 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Contributors: Return default array when posts empty to avoid notices.

Browse source 
Previously there were `undefined index` notices on `wp-admin/edit.php?post_type=5ftf_pledge` when a pledge had `0` posts in either status.
This commit is contained in:
Ian Dunn 2019-11-07 15:37:01 -08:00
parent 93d2bafd34
commit 521ce58de7
No known key found for this signature in database
GPG key ID: 99B971B50343CBCB
2 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
plugins/wporg-5ftf/includes/contributor.php
View file

@ -218,18 +218,22 @@ function get_pledge_contributors( $pledge_id, $status = 'publish', $contributor_
$posts = get_posts( $args ); $posts = get_posts( $args );
if ( 'all' === $status && ! empty( $posts ) ) { if ( 'all' === $status ) {
$initial = array( $initial = array(
'publish' => array(), 'publish' => array(),
'pending' => array(), 'pending' => array(),
); );
if ( empty( $posts ) ) {
$posts = $initial;
} else {
$posts = array_reduce( $posts, function( $carry, WP_Post $item ) { $posts = array_reduce( $posts, function( $carry, WP_Post $item ) {
$carry[ $item->post_status ][] = $item; $carry[ $item->post_status ][] = $item;
return $carry; return $carry;
}, $initial ); }, $initial );
} }
}
return $posts; return $posts;
} }

4
plugins/wporg-5ftf/includes/pledge-log.php
View file

@ -119,6 +119,10 @@ function add_log_entry( $pledge_id, $type, $message, array $data = array(), $use
$entry['user_id'] = $user_id; $entry['user_id'] = $user_id;
} elseif ( 'cli' === php_sapi_name() ) { } elseif ( 'cli' === php_sapi_name() ) {
/*
* `wp_shell`, etc can only be run from w.org sandboxes, and the hostname is the best way to identify
* which sandbox was used.
*/
$entry['user_id'] = gethostname(); $entry['user_id'] = gethostname();
} }