tec3/five-for-the-future
tec3/five-for-the-future
1
0
Fork 0
mirror of https://github.com/WordPress/five-for-the-future.git synced 2025-04-16 16:43:42 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Contributors: Apply ?? before array cast, to avoid PHP notice.

Browse source 
Previously the `$user->team_names` would be cast to an array before the null coalescing operator executed. If the `team_names` field wasn't set in the database, PHP would throw an error before trying to apply the null coalescing operator.
This commit is contained in:
Ian Dunn 2022-08-15 10:49:53 -07:00
parent 993bd53765
commit 8c28881812
No known key found for this signature in database
GPG key ID: 99B971B50343CBCB
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugins/wporg-5ftf/includes/contributor.php
View file

@ -652,7 +652,7 @@ function get_inactive_contributor_batch() : array {
}
$user->hours_per_week = absint( $user->hours_per_week ?? 0 );
$user->team_names = (array) $user->team_names ?? array();
$user->team_names = (array) ( $user->team_names ?? array() );
unset( $user->field_ids, $user->field_values ); // Remove the concatenated data now that it's exploded.
}