tec3/five-for-the-future
tec3/five-for-the-future
1
0
Fork 0
mirror of https://github.com/WordPress/five-for-the-future.git synced 2025-04-20 10:03:43 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Return early if contributor_post_id is missing

Browse source 
process_my_pledges_form() is actually called on page load in render_my_pledges().

So to prevent the unnecessary get_post() queries, let’s just return early if the form wasn’t really submitted.
This commit is contained in:
Caleb Burks 2019-11-06 00:33:28 -06:00
parent 85de3422ea
commit b105ec0099
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
plugins/wporg-5ftf/includes/contributor.php
View file

@ -306,11 +306,15 @@ function render_my_pledges() {
* @return string
*/
function process_my_pledges_form() {
$message = '';
$status = false;
$contributor_post_id = filter_input( INPUT_POST, 'contributor_post_id', FILTER_VALIDATE_INT );
$pledge = get_post( get_post( $contributor_post_id )->post_parent );
$nonce = filter_input( INPUT_POST, '_wpnonce', FILTER_SANITIZE_STRING );
if ( empty( $contributor_post_id ) || empty( $nonce ) ) {
return '';
}
$message = '';
$status = false;
$pledge = get_post( get_post( $contributor_post_id )->post_parent );
if ( filter_input( INPUT_POST, 'join_organization' ) ) {
wp_verify_nonce( $nonce, 'join_decline_organization' ) || wp_nonce_ays( 'join_decline_organization' );