My Pledges: Return early if contributor_post_id is missing.

`process_my_pledges_form()` is actually called on page load in `render_my_pledges()`.

So to prevent the unnecessary get_post() queries, let’s just return early if the form wasn’t really submitted.

See #87
This commit is contained in:
Caleb Burks 2019-11-06 00:33:28 -06:00 committed by Ian Dunn
parent 4b3586a487
commit c47679a5cc
No known key found for this signature in database
GPG key ID: 99B971B50343CBCB

View file

@ -306,11 +306,15 @@ function render_my_pledges() {
* @return string
*/
function process_my_pledges_form() {
$message = '';
$status = false;
$contributor_post_id = filter_input( INPUT_POST, 'contributor_post_id', FILTER_VALIDATE_INT );
$pledge = get_post( get_post( $contributor_post_id )->post_parent );
$nonce = filter_input( INPUT_POST, '_wpnonce', FILTER_SANITIZE_STRING );
if ( empty( $contributor_post_id ) || empty( $nonce ) ) {
return '';
}
$message = '';
$status = false;
$pledge = get_post( get_post( $contributor_post_id )->post_parent );
if ( filter_input( INPUT_POST, 'join_organization' ) ) {
wp_verify_nonce( $nonce, 'join_decline_organization' ) || wp_nonce_ays( 'join_decline_organization' );