tec3/five-for-the-future
tec3/five-for-the-future
1
0
Fork 0
mirror of https://github.com/WordPress/five-for-the-future.git synced 2025-07-03 09:41:19 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Create a validation function to do basic checking of form data

Browse source
This commit is contained in:
Kelly Dwan 2019-10-25 11:08:30 -04:00
parent e279f9ba49
commit e779397ce4
No known key found for this signature in database
GPG key ID: 8BA5575F3D11575D
1 changed files with 59 additions and 89 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

148
plugins/wporg-5ftf/includes/pledge-form.php
View file

@ -51,46 +51,31 @@ function render_form_new() {
*/ */
function process_form_new() { function process_form_new() {
$submission = get_form_submission(); $submission = get_form_submission();
$has_error = validate_submission( $submission );
$has_required = PledgeMeta\has_required_pledge_meta( $submission ); if ( $has_error ) {
return $has_error;
if ( is_wp_error( $has_required ) ) {
return $has_required;
}
$email = sanitize_meta(
PledgeMeta\META_PREFIX . 'org-pledge-email',
$submission['org-pledge-email'],
'post',
Pledge\CPT_ID
);
// todo make this validation DRY w/ process_form_manage().
if ( has_existing_pledge( $email, 'email' ) ) {
return new WP_Error(
'existing_pledge_email',
__( 'This email address is already connected to an existing pledge.', 'wporg' )
);
}
// todo should probably verify that email address is for the same domain as URL. do here and for manage.
$domain = PledgeMeta\get_normalized_domain_from_url( $submission['org-url'] );
if ( has_existing_pledge( $domain, 'domain' ) ) {
return new WP_Error(
'existing_pledge_domain',
__( 'A pledge already exists for this domain.', 'wporg' )
);
} }
$contributors = parse_contributors( $submission['pledge-contributors'] ); $contributors = parse_contributors( $submission['pledge-contributors'] );
if ( is_wp_error( $contributors ) ) { if ( is_wp_error( $contributors ) ) {
return $contributors; return $contributors;
} }
// Process image.
if ( ! function_exists('media_handle_upload') ) {
require_once( ABSPATH . 'wp-admin/includes/image.php' );
require_once( ABSPATH . 'wp-admin/includes/file.php' );
require_once( ABSPATH . 'wp-admin/includes/media.php' );
}
$logo = isset( $_FILES['org-logo'] ) ? $_FILES['org-logo'] : false;
if ( $logo ) {
$logo_id = \media_handle_sideload( $logo, 0 );
if ( is_wp_error( $logo_id ) ) {
return $logo_id;
}
}
$name = sanitize_meta( $name = sanitize_meta(
PledgeMeta\META_PREFIX . 'org-name', PledgeMeta\META_PREFIX . 'org-name',
$submission['org-name'], $submission['org-name'],
@ -108,34 +93,7 @@ function process_form_new() {
Contributor\create_new_contributor( $wporg_username, $new_pledge_id ); Contributor\create_new_contributor( $wporg_username, $new_pledge_id );
} }
// Process image. set_post_thumbnail( $new_pledge_id, $logo_id );
if ( ! function_exists('media_handle_upload') ) {
require_once( ABSPATH . 'wp-admin/includes/image.php' );
require_once( ABSPATH . 'wp-admin/includes/file.php' );
require_once( ABSPATH . 'wp-admin/includes/media.php' );
}
$logo = isset( $_FILES['org-logo'] ) ? $_FILES['org-logo'] : false;
if ( $logo ) {
if ( ! in_array( $logo['type'], [ 'image/png', 'image/jpg' ] ) ) {
return new WP_Error(
'invalid_image_type',
__( 'Logo file must be a png or jpg.', 'wporg' )
);
}
if ( ( $logo['size'] > 5 * MB_IN_BYTES ) ) {
return new WP_Error(
'invalid_image_size',
__( 'Logo file must be less than 5MB.', 'wporg' )
);
}
$result = \media_handle_sideload( $logo, $new_pledge_id );
if ( is_wp_error( $result ) ) {
return $result;
}
set_post_thumbnail( $new_pledge_id, $result );
}
return 'success'; return 'success';
} }
@ -179,34 +137,9 @@ function render_form_manage() {
*/ */
function process_form_manage() { function process_form_manage() {
$submission = get_form_submission(); $submission = get_form_submission();
$has_error = validate_submission( $submission );
$has_required = PledgeMeta\has_required_pledge_meta( $submission ); if ( $has_error ) {
return $has_error;
if ( is_wp_error( $has_required ) ) {
return $has_required;
}
$email = sanitize_meta(
PledgeMeta\META_PREFIX . 'org-pledge-email',
$submission['org-pledge-email'],
'post',
Pledge\CPT_ID
);
if ( has_existing_pledge( $email, 'email' ) ) {
return new WP_Error(
'existing_pledge_email',
__( 'This email address is already connected to an existing pledge.', 'wporg' )
);
}
$domain = PledgeMeta\get_normalized_domain_from_url( $submission['org-url'] );
if ( has_existing_pledge( $domain, 'domain' ) ) {
return new WP_Error(
'existing_pledge',
__( 'A pledge already exists for this domain.', 'wporg' )
);
} }
} }
@ -321,3 +254,40 @@ function parse_contributors( $contributors ) {
return $sanitized_contributors; return $sanitized_contributors;
} }
/**
* Check the submission for valid data.
*
* @return false|WP_Error
*/
function validate_submission( $submission ) {
$has_required = PledgeMeta\has_required_pledge_meta( $submission );
if ( is_wp_error( $has_required ) ) {
return $has_required;
}
$email = sanitize_meta(
PledgeMeta\META_PREFIX . 'org-pledge-email',
$submission['org-pledge-email'],
'post',
Pledge\CPT_ID
);
if ( has_existing_pledge( $email, 'email' ) ) {
return new WP_Error(
'existing_pledge_email',
__( 'This email address is already connected to an existing pledge.', 'wporg' )
);
}
$domain = PledgeMeta\get_normalized_domain_from_url( $submission['org-url'] );
if ( has_existing_pledge( $domain, 'domain' ) ) {
return new WP_Error(
'existing_pledge_domain',
__( 'A pledge already exists for this domain.', 'wporg' )
);
}
return false;
}